[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2 v3] Python: Refactoring virTypedParameter conversion for NUMA tuning APIs



On 01/29/2012 03:29 PM, Guannan Ren wrote:
On 01/29/2012 01:39 PM, Alex Jia wrote:
On 01/28/2012 10:53 PM, Guannan Ren wrote:
         *virDomainSetNumaParameters
         *virDomainGetNumaParameters
---
  python/Makefile.am              |    4 +-
  python/libvirt-override-api.xml |   13 ++
python/libvirt-override.c | 314 +++++++++++++++++++++++++++++++++++++++
  3 files changed, 330 insertions(+), 1 deletions(-)

diff --git a/python/Makefile.am b/python/Makefile.am
index 3068eee..4302fa5 100644
--- a/python/Makefile.am
+++ b/python/Makefile.am
@@ -8,6 +8,8 @@ SUBDIRS= . tests
  INCLUDES = \
      $(PYTHON_INCLUDES) \
      -I$(top_srcdir)/include \
+        -I$(top_srcdir)/src \
+        -I$(top_srcdir)/gnulib/lib \
      -I$(top_builddir)/include \
      -I$(top_builddir)/$(subdir) \
      $(GETTEXT_CPPFLAGS)
@@ -42,7 +44,7 @@ all-local: libvirt.py libvirt_qemu.py

  pyexec_LTLIBRARIES = libvirtmod.la libvirtmod_qemu.la

-libvirtmod_la_SOURCES = libvirt-override.c typewrappers.c
+libvirtmod_la_SOURCES = libvirt-override.c typewrappers.c ../src/util/virtypedparam.c
It exists a compilation error for me:

make[3]: Entering directory `/home/ajia/Workspace/libvirt/python'
  CC     libvirtmod_la-libvirt-override.lo
In file included from ../src/util/virtypedparam.h:26,
                 from libvirt-override.c:24:
../src/internal.h:253:23: error: probes.h: No such file or directory
make[3]: *** [libvirtmod_la-libvirt-override.lo] Error 1


      did you add "-I$(top_srcdir)/src" in  python/Makefile.am
      it tell where to get the ./src/probes.h

It seems I must to install systemtap-sdt-devel on rhel, then libvirt will check whether 'dtrace' enable, the issue is whether it should complication fails if lack of 'dtrace', if so, we should tell user to install systemtap-sdt-devel package as a pre-requirement, however, lack of probes.h doesn't affect compilation for people not using dtrace, for details, please see following link:
http://www.redhat.com/archives/libvir-list/2010-October/msg00886.html

Regards,
Alex


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]