[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [[libvirt-glib PATCHv3] 1/3] Add proper error reporting to gvir_storage_vol_get_path



On Tue, Jan 31, 2012 at 03:34:09PM +0100, Christophe Fergeau wrote:
> gvir_storage_vol_get_name currently call g_error when an error occurs.
> Since g_error trigger a coredump, calling it in a library is harmful.
> Replace this with proper GError error reporting.
> ---
>  libvirt-gobject/libvirt-gobject-storage-vol.c |    7 +++++--
>  libvirt-gobject/libvirt-gobject-storage-vol.h |    2 +-
>  2 files changed, 6 insertions(+), 3 deletions(-)

ACK


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]