[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 0/5] Virtio support for S390



On 29.06.2012 17:02, Viktor Mihajlovski wrote:
> As 0.9.13 is stabilizing and I will not be available next week
> I am sending this reworked patch set already today, looking forward
> to comments.
> 
> This series adds support for the s390 flavor of virtio devices.
> Since the s390 virtio devices are not implemented as PCI devices
> it is necessary to refactor some of the device address assignment
> code.
> 
> v2 changes
>    resent as thread
> 
> v3 changes
>    renumbered new virtio-s390 capability
>    fixed incorrect whitespace
>    fixed subject lines
> 
> Viktor Mihajlovski (5):
>   qemu: Extended qemuDomainAssignAddresses to be callable from
>     everywhere.
>   qemu: Change tests to use (modified) qemuDomainAssignAddresses
>   S390: Add support for virtio-s390 devices.
>   S390: Domain Schema for s390-virtio machines.
>   S390: Adding testcases for s390
> 
>  docs/schemas/domaincommon.rng                      |   20 +++
>  src/conf/domain_conf.c                             |   11 +-
>  src/conf/domain_conf.h                             |    1 +
>  src/qemu/qemu_capabilities.c                       |    7 +
>  src/qemu/qemu_capabilities.h                       |    1 +
>  src/qemu/qemu_command.c                            |  139 ++++++++++++++++++--
>  src/qemu/qemu_command.h                            |    6 +-
>  src/qemu/qemu_driver.c                             |   14 +-
>  src/qemu/qemu_process.c                            |   42 +------
>  .../qemuxml2argv-console-virtio-s390.args          |    9 ++
>  .../qemuxml2argv-console-virtio-s390.xml           |   24 ++++
>  .../qemuxml2argv-disk-virtio-s390.args             |    5 +
>  .../qemuxml2argv-disk-virtio-s390.xml              |   22 +++
>  .../qemuxml2argv-minimal-s390.args                 |    5 +
>  .../qemuxml2argvdata/qemuxml2argv-minimal-s390.xml |   21 +++
>  .../qemuxml2argv-net-virtio-s390.args              |    5 +
>  .../qemuxml2argv-net-virtio-s390.xml               |   22 +++
>  tests/qemuxml2argvtest.c                           |   20 ++--
>  tests/qemuxmlnstest.c                              |   13 +--
>  tests/testutilsqemu.c                              |   31 +++++
>  20 files changed, 332 insertions(+), 86 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-console-virtio-s390.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-console-virtio-s390.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-s390.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-s390.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-minimal-s390.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-virtio-s390.args
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-virtio-s390.xml
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list
> 

Overall I think this is in a good shape except patch 3/5 where we are
missing some documentation. So Viktor, if you'll send it into the list I
can push this then. I am keeping this patch set on my local branch with
all diffs I've pointed out squashed in. So there's no need to resend
whole set again.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]