[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Only enforce check for YAJL when starting a VM



On 07/04/2012 03:47 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The previous check for YAJL would have many undesirable
> consequences, the most important being that it caused the
> capabilities XML to loose all <guest> elements. There is

s/loose/lose/

> no user visible feedback as to what is wrong in this respect,
> merely a syslog message. The empty capabilities causes
> libvirtd to then throw away all guest XML configs that are
> stored.
> 
> This changes the code so that the check for YAJL is only
> performed at the time we attempt to spawn a QEMU process
> 
> error: Failed to start domain vm-vnc
> error: unsupported configuration: this qemu binary requires libvirt to be compiled with yajl
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---

ACK.

This code will all be touched again the day we learn how to cache
capabilities rather than reprobing them all the time, but as that patch
has not been written and this is an improvement in behavior, it is worth
pushing this now.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]