[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/15] Avoid build shared source files again for libvirt_lxc



On Wed, Jul 04, 2012 at 06:39:46AM -0600, Eric Blake wrote:
> On 07/03/2012 09:58 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > Currently the build of libvirt_lxc will cause recompilation
> > of all sources under src/util, src/conf, src/security and
> > more. Switch the libvirt_lxc process to link against the
> > libtool convenience libraries that are already built as
> > part of the main libvirt.os & libvirtd build process
> > 
> > Signed-off-by: Daniel P. Berrange <berrange redhat com>
> > ---
> >  src/Makefile.am |   39 ++++++++-------------------------------
> >  1 file changed, 8 insertions(+), 31 deletions(-)
> 
> Does this mean we can clean up the $(DOMAIN_LIST_SOURCES) hack from
> commit 2c68080, where we had a link failure on libvirt_lxc when trying
> to pull in src/conf/virdomainlist.c?

I don't recall what the problem was, but it looks like that bit of the
makefile could be cleaned up. I'd expect anything that's in the conf/
directory to be listed under the same _SOURCES variable.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]