[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 3/4] test: Add new test case for nodeinfotest



On 07/10/2012 04:56 AM, Michal Privoznik wrote:
> On 09.07.2012 17:17, Peter Krempa wrote:
>> This patch adds test data that describe a machine that has two physical
>> processors that don't share same core id's on their cores. On this data
>> the "virsh nodeinfo" reported that the machine had 10 cores per socket
>> while the processor had only 8. (Before fixing nodeinfo gathering code).

>> +fpu		: yes
>> +fpu_exception	: yes
>> +cpuid level	: 11
>> +wp		: yes
>> +flags		: fpu vme de pse tsc msr pae mce cx8 apic mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good xtopology nonstop_tsc aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 cx16 xtpr pdcm dca sse4_1 sse4_2 x2apic popcnt aes lahf_lm ida arat epb dts tpr_shadow vnmi flexpriority ept vpid
>> +bogomips	: 5319.83
>> +clflush size	: 64
>> +cache_alignment	: 64
>> +address sizes	: 44 bits physical, 48 bits virtual
>> +power management:
>> +
> 
> Don't add empty newline here.

We have an explicit whitespace exemption for these sorts of files, so
that they can match actual machine outputs with their trailing empty
line.  This particular file will not trigger either a syntax check error
or a commit hook rejection.

> 
> ACK modulo empty newline.

Empty newline is fine in this case, actually.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]