[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix a string format bug in qemu_cgroup.c



On 07/05/2012 09:08 PM, Wen Congyang wrote:
> At 07/06/2012 09:53 AM, tangchen Wrote:
>> Signed-off-by: Tang Chen <tangchen cn fujitsu com>
>> ---
>>  src/qemu/qemu_cgroup.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
>> index f8f375f..662d41d 100644
>> --- a/src/qemu/qemu_cgroup.c
>> +++ b/src/qemu/qemu_cgroup.c
>> @@ -473,8 +473,8 @@ cleanup:
>>          rc = virCgroupSetCpuCfsPeriod(cgroup, old_period);
>>          if (rc < 0)
>>              virReportSystemError(-rc,
>> -                                 _("%s"),
>> -                                 "Unable to rollback cpu bandwidth period");
>> +                                 "%s",
>> +                                 _("Unable to rollback cpu bandwidth period"));
>>      }
>>
>>      return -1;
> 
> ACK
> 
> I use make syntax-check , and do not find this bug...

That says our syntax-check rule is not strong enough.  I'll work on a
patch for that, as there are other violations of this bug.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org



Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]