[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: detect all improper uses of _("%s")



On 07/10/12 23:38, Eric Blake wrote:
The only useful translation of "%s" as a format string is "%s" (I
suppose you could claim "%$1s" is also valid, but why bother).  So
it is not worth translating; fixing this exposes some instances
where we were failing to translate real error messages.

* cfg.mk (sc_prohibit_useless_translation): New rule.
* src/lxc/lxc_driver.c (lxcSetVcpuBWLive): Fix offender.
* src/openvz/openvz_conf.c (openvzReadFSConf): Likewise.
* src/qemu/qemu_cgroup.c (qemuSetupCgroupVcpuBW)
(qemuSetupCgroupForVcpu): Likewise.
* src/qemu/qemu_driver.c (qemuSetVcpusBWLive): Likewise.
* src/xenapi/xenapi_utils.c (xenapiSessionErrorHandle): Likewise.
---

This is a followup to:
https://www.redhat.com/archives/libvir-list/2012-July/msg00403.html

  cfg.mk                    |    6 ++++++
  src/lxc/lxc_driver.c      |    5 ++---
  src/openvz/openvz_conf.c  |    5 ++---
  src/qemu/qemu_cgroup.c    |   12 +++++-------
  src/qemu/qemu_driver.c    |    5 ++---
  src/xenapi/xenapi_utils.c |    8 +++++---
  6 files changed, 22 insertions(+), 19 deletions(-)

ACK.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]