[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/13] Introduce the function virCgroupForHypervisor



hi~

On 07/10/2012 08:44 PM, Eric Blake wrote:
> The subject should include 'v2' to mention that this is a respin; you
> can do that with 'git send-email --subject-prefix=PATCHv2'.
> 
> On 07/10/2012 03:11 AM, tangchen wrote:
>> Introduce the function virCgroupForHypervisor() to create sub directory
>> for hypervisor thread(include I/O thread, vhost-net thread)
> 
> So if I understand correctly, the intent is to create this hierarchy:
> 
> cgroup mount point(s) (top-level controllers)
> - libvirt (subdirectory for all libvirt cgroups)
> --- qemu (all groups tied to a driver, virCgroupForDriver)
> ----- $name (all groups tied to a VM, virCgroupForDomain)
> ------- $vcpuN (one group per vcpu, virCgroupForVcpu)
> ------- hypervisor (one catchall group for non-vcpu, virCgroupForHypervisor)
> 
> where hypervisor and vcpuN directories are siblings, both adding up to
> the sum total of $name for the VM totals.
> 
Yes, that's right. :)

> If so, please document that in the commit message.
> 
OK, I'll do it soon. :)
Please have a look at the other patches. If there is any other problems, 
please let me know, and I'll fix them all in v3 patch.

BTW, I'm not in a hurry. So please take your time. :)
Thanks.:)

>>
>> Signed-off-by: Wen Congyang <wency cn fujitsu com>
> 
> Still doesn't have the correct git authorship; git send-email would
> automatically insert a line:
> 
> From: Wen Congyang <wency cn fujitsu com>
> 
> if you had correctly attributed authorship.  I can fix that as needed,
> though.
> 
>> ---
>>  .gnulib                  |    2 +-
> 
> Oops; gnulib submodule updates should generally be an independent patch,
> it looks like it was an accident that you bumped it on this patch.
> 
OK, I got it and I'll fix it, thanks. :)

> Other than that, this patch looks okay.
> 

-- 
Best Regards,
Tang chen


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]