[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH]POWER Hypervisor: Fix the segment fault issue for the "list" command



On 07/11/2012 06:05 PM, Dennis Chen wrote:
When connect to the remote IBM HMC/IVM server, the remoteNetworkOpen() called
after the phypOpen() in do_open function will re-assign a NULL pointer to the
virConnectPtr conn->networkPrivateData which is allocated in phypOpen(), this
will result in a segment fault issue when execute the following commands,
eg, "virsh# list --all"

Signed-off-by: Dennis Chen<dennis chen tnsoft com cn>
---
   src/remote/remote_driver.c |    3 ++-
   1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index eac50e6..22ef129 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -2504,7 +2504,8 @@ static virDrvOpenStatus ATTRIBUTE_NONNULL (1)
   remoteGenericOpen(virConnectPtr conn, virConnectAuthPtr auth,
                     unsigned int flags, void **genericPrivateData)
   {
-    if (inside_daemon)
+    if (inside_daemon ||
+       STREQ (conn->driver->name, "PHYP"))
           return VIR_DRV_OPEN_DECLINED;

       if (conn->driver&&

BRs,
Dennis


Resending to CC Eduardo, the author of phyp driver...


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]