[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Remove all use of virRun in storage code



On 07/11/2012 10:30 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> To make it easier to dynamically change the command line ARGV,
> switch all storage code over to use virCommandPtr APIs for
> running programs
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---

> @@ -1623,8 +1617,8 @@ virStorageBackendRunProgNul(virStoragePoolObjPtr pool,
>      }
>  
>      if (feof (fp) < 0) {
> -        virReportSystemError(errno,
> -                             _("read error on pipe to '%s'"), prog[0]);
> +        virReportSystemError(errno, "%s",
> +                             _("read error on pipe"));

Is it worth s/feof /feof/ while touching this hunk?

Other than that, ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]