[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] fix failure when building with --disable-debug



On 07/11/2012 07:28 PM, Hu Tao wrote:

>>>  #  define VIR_DEBUG_INT(category, f, l, ...)    \
>>> -    do { } while (0)
>>> +    virLogEatParam((void*)category, f, l, __VA_ARGS__)
>>
>> Any reason we have to use a cast, instead of just creating our eat
>> function with the correct type parameter in the first place?
> 
> I just wanted to make the function more generic.

No need to make it more generic unless we actually use it in more than
one place.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org



Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]