[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/2] Avoid touching monitor when fetching guest XML or info

On Thu, Jul 12, 2012 at 11:45:55PM +0800, Guannan Ren wrote:
> The virDomainGetXMLDesc and virDomainGetInfo APIs for QEMU suffer
> from needing to run 'query-balloon' to update the balloon level.
> This has caused us performance problems and even worse caused us
> to lock up on a dead QEMU.
> The following two patches to QEMU add a BALLOON_EVENT and a query-events
> command to QMP. With those two parts, we can avoiding running the
> query-balloon command at all.

Thanks for re-posting these patches - but in the future, if you are going
to take over someone else's patches it would be a good idea to contact
them beforehand to let them know - this would save possible duplicated

Obviously these patches get my ACK, but someone else needs to review them
really :-)

|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]