[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3] docs: Improve patch submission guidelines



On 16.07.2012 10:06, Daniel P. Berrange wrote:
> On Fri, Jul 13, 2012 at 02:45:34PM -0600, Eric Blake wrote:
>> On 07/12/2012 03:44 AM, Michal Privoznik wrote:
>>> We should really advise (new) developers to send rebased patches
>>> that apply cleanly and use git-send-email rather than all other
>>> obscure ways.
>>> ---
>>> diff to v2:
>>> -Eric's suggestions worked in
>>>
>>>  HACKING              |   37 ++++++++++++++++++++++++++++++++++++-
>>>  docs/hacking.html.in |   49 ++++++++++++++++++++++++++++++++++++++++++++-----
>>>  2 files changed, 80 insertions(+), 6 deletions(-)
>>
>> ACK with one spelling nit fixed.
>>
>>> +++ b/docs/hacking.html.in
>>> @@ -11,19 +11,58 @@
>>>  
>>>        <li><p>Post patches in unified diff format.  A command similar to this
>>>          should work:</p>
>>> -<pre>
>>> +<del><pre>
>>
>> I'm not familiar with the <del> tag, but assume it made a useful
>> difference.  At any rate, the toolchain didn't choke on it.
> 
> Use of the <del> tag seems rather odd here. I don't think it should
> be used. Semantically it is used to mark a piece of text as "deleted"
> while leaving it in place. Typically this would be rendered in a
> different colour, perhaps with a line through.
> 
> 
> Daniel
> 

Okay, I've dropped the <del> tag and fixed spelling. Thanks.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]