[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 10/13] Turn virKeepAlive into a virObject



<...>

> @@ -179,20 +195,13 @@ virKeepAliveTimer(int timer ATTRIBUTE_UNUSED, void *opaque)
>      }
>  
>      virKeepAliveLock(ka);
> -    ka->refs--;
> +    virObjectUnref(ka);
>  
>  cleanup:
>      virKeepAliveUnlock(ka);
>  }

virObjectUnref may have freed ka and we are going to unlock a freed
object.  We can safely remove lock/unlock here.

-- 
Thanks,
Hu Tao


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]