[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] [libvirt-java] Fix javadoc warnings.



On 07/19/2012 06:31 AM, Claudio Bley wrote:
> ping... ?!
> 
> Isn't this the appropriate list? What's the status of libvirt-java?

This is the right list.  Unfortunately, at the moment libvirt-java does
not have an active maintainer; there have been several patches proposed
lately by various individuals, and they are slowly getting applied as
people have time, but there's a lot more work to be done to catch
libvirt-java up to being an accurate binding to the latest C interface.
 Submit enough patches and you can earn the commit rights to become such
a maintainer, and get these patches reviewed with less delay :)

Personally, it's been years since I've written in Java, so I have kind
of shied away from reviewing libvirt-java patches, so I'm probably not
helping the situation of libvirt-java being out of date.  But this
particular patch is easy to review - no code changes, just doc fixes, so
I would be inclined to push it if it didn't take more than 2 minutes of
my time.

> 
> At Mon, 09 Jul 2012 10:23:42 +0200,
> Claudio Bley wrote:
>> Here's a patch fixing these javadoc warnings:
>>
>> ---
>>   [javadoc] x:\src\libvirt-java\src\main\java\org\libvirt\Connect.java:387: warning - @return tag has no arguments.

Your patch looks reasonable, but it was not in a format that 'git am'
recognizes.  Can you re-submit as a formal patch using 'git send-email',
to make it easier for maintainers to apply your patch without massaging
it first?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]