[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 19/23] Replace use of qemuReportError with virReportError



On Thu, Jul 19, 2012 at 12:51:04PM +0200, Peter Krempa wrote:
> On 07/18/12 20:40, Daniel P. Berrange wrote:
> >From: "Daniel P. Berrange" <berrange redhat com>
> >
> >Update the QEMU driver to use virReportError instead of
> >the qemuReportError custom macro
> >
> >Signed-off-by: Daniel P. Berrange <berrange redhat com>
> >---
> >  cfg.mk                       |    1 -
> >  src/qemu/qemu_agent.c        |  142 ++--
> >  src/qemu/qemu_capabilities.c |   16 +-
> >  src/qemu/qemu_cgroup.c       |   26 +-
> >  src/qemu/qemu_command.c      | 1066 ++++++++++++------------
> >  src/qemu/qemu_conf.c         |   26 +-
> >  src/qemu/qemu_conf.h         |    4 -
> >  src/qemu/qemu_domain.c       |   94 +--
> >  src/qemu/qemu_driver.c       | 1834 +++++++++++++++++++++---------------------
> >  src/qemu/qemu_hostdev.c      |   59 +-
> >  src/qemu/qemu_hotplug.c      |  362 ++++-----
> >  src/qemu/qemu_migration.c    |  284 +++----
> >  src/qemu/qemu_monitor.c      |  384 ++++-----
> >  src/qemu/qemu_monitor_json.c |  546 ++++++-------
> >  src/qemu/qemu_monitor_text.c |  532 ++++++------
> >  src/qemu/qemu_process.c      |  216 ++---
> >  16 files changed, 2795 insertions(+), 2797 deletions(-)
> >
> 
> ACK, mechanic, but *HUGE*. While reviewing I found some places that
> would require polishing but are pre-existing. I'm attatching the
> patch for that.
> 
> Peter
> 

> From 071801e62511cc9db451f18a87d1f0ab772687d3 Mon Sep 17 00:00:00 2001
> Message-Id: <071801e62511cc9db451f18a87d1f0ab772687d3 1342695008 git pkrempa redhat com>
> From: Peter Krempa <pkrempa redhat com>
> Date: Thu, 19 Jul 2012 12:48:12 +0200
> Subject: [PATCH] qemu: Add missing "%s" before translation macros and break
>  long lines.
> 
> This patch cleans up some missing "%s" before translation macros, breaks
> long lines and some other style cleanups found while reviewing DanPB's
> massive cleanup for virReportError.

Mixing actual bug fixes (missing "%s") with whitespace/style cleanups
is a bad idea.  I've pushed a cut down version of your patch, which
just applies the "%s" fixes. Feel free to update what's left of your
style cleanup & repost

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]