[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic ops code



On 07/18/2012 07:07 PM, Hu Tao wrote:
> <...>
> 
>> +
>> +#  define virAtomicIntGet(atomic)                                       \
>> +    (__extension__ ({                                                   \
>> +            verify (sizeof(*(atomic)) == sizeof(int));                  \
>> +            (void) (0 ? *(atomic) ^ *(atomic) : 0);                     \
>> +            __sync_synchronize ();                                      \
>> +            (int) *(atomic);                                            \
>> +        }))

> 
> The `verify' lines cause building warnings:
> 
> cc1: warnings being treated as errors
> util/virobject.c: In function 'virClassNew':
> util/virobject.c:74:99: error: nested extern declaration of '_gl_verify_function2' [-Wnested-externs]

Which version of gcc?

I'll have to see if I can come up with a solution in upstream gnulib
that expands verify() in such a way that works with -Wnested-externs.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]