[libvirt] [PATCH 1/2] Added timestamps to storage volumes
Eric Blake
eblake at redhat.com
Thu Jul 19 14:18:24 UTC 2012
On 07/19/2012 01:13 AM, Hendrik Schwartke wrote:
> The access, birth, modification and change times are added to
> storage volumes and corresponding xml representations.
> ---
> docs/formatstorage.html.in | 27 +++++++++++++++++++++++++++
> docs/schemas/storagevol.rng | 39 +++++++++++++++++++++++++++++++++++++++
> src/conf/storage_conf.c | 21 +++++++++++++++++++++
> src/conf/storage_conf.h | 13 +++++++++++++
> src/storage/storage_backend.c | 21 +++++++++++++++++++++
> 5 files changed, 121 insertions(+)
>
> diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in
> index d0e4319..d8ffbea 100644
> --- a/docs/formatstorage.html.in
> +++ b/docs/formatstorage.html.in
> @@ -141,6 +141,20 @@
> <mode>0744</mode>
> <label>virt_image_t</label>
> </permissions>
> + <timestamps>
> + <atime>
> + <sec>1341933637</sec>
> + <nsec>27319099</nsec>
Just because C can't represent struct timespec as a single number
doesn't mean that our XML has to suffer; I still think %d.%09lld is a
better format than splitting <sec> and <nsec> into separate elements.
On the other hand, will XPath queries of the XML be easier if it is a
floating point number compared to two different elements? Does anyone
else have an opinion on which color to paint this bikeshed?
--
Eric Blake eblake at redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 620 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20120719/b5c9ef20/attachment-0001.sig>
More information about the libvir-list
mailing list