[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/23] Replace use of testError with virReportError



On 07/18/12 20:40, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange redhat com>

Update the test driver to use virReportError instead of the
testError custom macro

Signed-off-by: Daniel P. Berrange <berrange redhat com>
---
  src/test/test_driver.c |  509 ++++++++++++++++++++++++------------------------
  1 file changed, 255 insertions(+), 254 deletions(-)


@@ -1973,7 +1972,7 @@ static int testDomainCoreDump(virDomainPtr domain,
                                    domain->name);

      if (privdom == NULL) {
-        testError(VIR_ERR_INVALID_ARG, __FUNCTION__);
+        virReportError(VIR_ERR_INVALID_ARG, __FUNCTION__);
          goto cleanup;
      }


Parts like this above probably also require "%s", treatment.

ACK as the problem above persists longer.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]