[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] Add callback to virNetClient to be invoked on connection close



On 07/19/2012 09:04 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Allow detection of socket close in virNetClient via an callback
> function, triggered on any condition that causes the socket to
> be close.
> 
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---

> @@ -463,6 +480,9 @@ void virNetClientFree(virNetClientPtr client)
>          return;
>      }
>  
> +    if (client->closeFf && client->closeOpaque)
> +        client->closeFf(client->closeOpaque);

Again, you should not be forcing closeOpaque to be non-NULL.  It's
opaque, after all.

> @@ -534,7 +561,7 @@ virNetClientCloseLocked(virNetClientPtr client)
>  static void virNetClientCloseInternal(virNetClientPtr client,
>                                        int reason)
>  {
> -    VIR_DEBUG("client=%p", client);
> +    VIR_DEBUG("client=%p wantclose=%d", client, client ? client->wantClose : false);

Passing 'false' to %d looks odd, but works.  If, per my 2/5 comments,
you merge wantClose into closeReason, then you'd have an int instead of
a bool to print here.

ACK, once you fix the non-NULL opaque limitation.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org



Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]