[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 17/23] Replace use of VMX_ERROR with virReportError



On 07/20/2012 07:34 AM, Martin Kletzander wrote:
> On 07/18/2012 08:40 PM, Daniel P. Berrange wrote:
>> From: "Daniel P. Berrange" <berrange redhat com>
>>
>> Update the VMX shared code to use virReportError instead of
>> the VMX_ERROR custom macro
>>

>> @@ -3676,9 +3672,9 @@ virVMXFormatSerial(virVMXContext *ctx, virDomainChrDefPtr def,
>>              break;
>>  
>>            default:
>> -            VMX_ERROR(VIR_ERR_CONFIG_UNSUPPORTED,
>> -                      _("Unsupported character device TCP protocol '%s'"),
>> -                      virDomainChrTcpProtocolTypeToString(
>> +            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>> +                           _("Unsupported character device TCP protocol '%s'"),
>> +                           virDomainChrTcpProtocolTypeToString(
>>                            def->source.data.tcp.protocol));
> 
> I'd probably indent the "def->source..." line differently so it's more
> visible that it is one level deeper.
> 

> 
> One remark up there, but no biggie.

I had to hunt for that remark among 70k of verbatim patch.  Not only is
it okay to trim portions of the patch that you are happy with, but
trimming actually helps focus on the problems.  Just be sure you leave
enough context to help the readers pinpoint where the problem was (as I
did here, by including the @@ line at the start of the problematic hunk).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]