[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/3] Make sure xenHypervisorInit correctly reports errors



On 07/20/12 16:11, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange redhat com>

The xenHypervisorInit method was called from two different
locations, during initial driver registration and also while
opening a Xen connection. The former can't report any useful
errors to the end user/app, so remove it. To ensure thread
safety use a VIR_ONCE_GLOBAL_INIT call to invoke
xenHypervisorInit from the xenHypervisorOpen method.
---
  src/xen/xen_driver.c     |    3 ---
  src/xen/xen_hypervisor.c |   31 ++++++++++---------------------
  2 files changed, 10 insertions(+), 24 deletions(-)


This version definitely looks better. ACK.

Peter


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]