[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] Add callback to virNetClient to be invoked on connection close



On 07/20/2012 08:18 AM, Daniel P. Berrange wrote:
>>> @@ -463,6 +480,9 @@ void virNetClientFree(virNetClientPtr client)
>>>          return;
>>>      }
>>>  
>>> +    if (client->closeFf && client->closeOpaque)
>>> +        client->closeFf(client->closeOpaque);
>>
>> Again, you should not be forcing closeOpaque to be non-NULL.  It's
>> opaque, after all.
> 
> If opaque is NULL, then there's nothing that needs free'ing.

Maybe nothing to free, but there may still be side effects (such as
logging) in the closeFf that the caller still wants to have happen.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org



Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]