[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/3] Use standard naming prefix for SELinux driver function names

On 07/20/2012 10:59 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> The function names in the SELinux driver all start with
> SELinux or 'mcs' as a prefix. Sanitize this so that they
> all use 'virSecuritySELinux' as the prefix
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/security/security_selinux.c |  394 ++++++++++++++++++++-------------------
>  1 file changed, 198 insertions(+), 196 deletions(-)

Mechanical.  ACK.

> @@ -487,12 +489,12 @@ SELinuxSecurityDriverClose(virSecurityManagerPtr mgr)
>  }
> -static const char *SELinuxSecurityGetModel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED)
> +static const char *virSecuritySELinuxSecurityGetModel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED)

For hunks like this, do you want to reformat to:

static const char *
virSecuritySELinuxSecurityGetModel(virSecurityManagerPtr mgr

to avoid the long lines?  But that's cosmetic, and doesn't get in the
way of my ack.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]