[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic ops code



On 07/20/2012 04:26 PM, Eric Blake wrote:
>>>>> +#  define virAtomicIntGet(atomic)                                       \
>>>>> +    (__extension__ ({                                                   \
>>>>> +            verify (sizeof(*(atomic)) == sizeof(int));                  \

> within functions, use this instead:
> 
> (void)verify_true(...)

Or this, to give a better error message where possible:

(void) verify_expr (sizeof(*(atomic)) == sizeof(int), "wrong size");

> 
> The cast to void is unfortunately necessary to avoid a -Wall of
> 'statement with no effect'.

Likewise true of verify_expr().

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]