[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] fixed segfault in virauth



On 07/23/2012 12:51 PM, Martin Kletzander wrote:
> No check for conn->uri being NULL in virAuthGetConfigFilePath (valid state) made the client segfault. This happens with fresh defalt VDSM configuration for example.
> 
> The check ought to be enough as conn->uri being NULL is valid in later code.
> ---
>  src/util/virauth.c |   20 +++++++++++---------
>  1 files changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/src/util/virauth.c b/src/util/virauth.c
> index e6b1db0..2c1a4ae 100644
> --- a/src/util/virauth.c
> +++ b/src/util/virauth.c
> @@ -1,7 +1,7 @@
>  /*
>   * virauth.c: authentication related utility functions
>   *
> - * Copyright (C) 2010 Matthias Bolte <matthias bolte googlemail com>
> + * Copyright (C) 2010, 2012 Matthias Bolte <matthias bolte googlemail com>

Wrong copyright attribution.

ACK once you fix that.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]