[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/11] Split virsh



On 07/23/2012 01:29 AM, Osier Yang wrote:
> This splits virsh.c by the command groups, except 'virsh itself' group,
> each group will have a separate .c, filled with the its commands, a
> few helpers, and command group definition moved from virsh.c. and virsh.c
> simply include those new .c files.
> 
> It still could be optimized, but this set could set up the skelton, and
> further optimization could be later patches.
> 
> Osier Yang (11):
>   virsh: Move definition of cmds and cmd groups right at the top of
>     main
>   virsh: Split cmds for domain and domain monitoring from virsh.c
>   virsh: Split cmds for storage pool and storage volume from virsh.c
>   virsh: Split cmds to manage network from virsh.c
>   virsh: Split cmds to manage host interface from virsh.c
>   virsh: Split cmds to manage network filter from virsh.c
>   virsh: Split cmds to manage secret from virsh.c
>   virsh: Split cmds to manage domain snapshot from virsh.c
>   virsh: Split cmds in host group from virsh.c
>   virsh: Split cmds in node device group from virsh.c
>   virsh: Move command group definition into its own file

Patches 2 and 3 didn't come through yet (too big for the mail list, when
uncompressed), but I'm in favor of the overall idea. I'll review what I
can of the incomplete series; this has the potential to introduce
conflicts in other pending patches, but is worth doing.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]