[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Clarify that memtune parameters may be rounded in the man page



On 07/24/2012 02:50 AM, Jan Tomko wrote:
> ---
>  tools/virsh.pod |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index b4a3d5c..6ecf6ce 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -1366,7 +1366,10 @@ appropriate limit is adjusted if supported by the hypervisor.  LXC and
>  QEMU/KVM support I<--hard-limit>, I<--soft-limit>, and I<--swap-hard-limit>.
>  I<--min-guarantee> is supported only by ESX hypervisor.  Each of these
>  limits are scaled integers (see B<NOTES> above), with a default of
> -kibibytes (blocks of 1024 bytes) if no suffix is present.
> +kibibytes (blocks of 1024 bytes) if no suffix is present. Libvirt rounds
> +up to the nearest kibibyte.  Some hypervisors require a larger granularity
> +than KiB, and requests that are not an even multiple will be rounded up.
> +For example, vSphere/ESX rounds the parameter up to mebibytes (1024 kibibytes).

ACK (I had to check the code to make sure).

Pushed, after adding you to AUTHORS.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]