[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] fixed SegFault in virauth



On 07/24/2012 08:08 AM, Martin Kletzander wrote:
> No check for conn->uri being NULL in virAuthGetConfigFilePath (valid
> state) made the client segfault. This happens for example with these
> settings:
>  - no virtualbox driver installed (modifies conn->uri)
>  - no default URI set (VIRSH_DEFAULT_CONNECT_URI="",
>    LIBVIRT_DEFAULT_URI="", uri_default="")
>  - auth_sock_rw="sasl"
>  - virsh run as root
> 
> That are unfortunately the settings with fresh Fedora 17 installation
> with VDSM.
> 
> The check ought to be enough as conn->uri being NULL is valid in later
> code and is handled properly.
> ---
> v2:
>  - copyright modified properly this time

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]