[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/13] virsh: Split cmds of storage pool group from virsh.c



On 07/24/12 11:18, Osier Yang wrote:
This splits commands of storage pool group into virsh-pool.c,
The helpers not for common use are moved too. Standard copyright
is added for the new file.

* tools/virsh.c:
   Remove commands for storage storage pool and a few helpers.
   (vshCommandOptVol, vshCommandOptVolBy).

* tools/virsh-pool.c:
   New file, filled with commands of storage pool group and its
   helpers.
---
  tools/virsh-pool.c | 1415 +++++++++++++++++++++++++++++++++++++++++++
  tools/virsh.c      | 1690 +++++-----------------------------------------------
  2 files changed, 1556 insertions(+), 1549 deletions(-)
  create mode 100644 tools/virsh-pool.c


Again, I checked that additions match removals and that aditions are not modified. Also this file has some functions that would deserve to be in a utils file.

As this is a first step into splitting virsh I'm fine with this.

ACK

Peter





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]