[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 00/13 v2] Split virsh



There were patches on virsh committed since this set created. I run
out of time today to resolve the conflicts to push the set. Please
wait a while if you have any changes on virsh (to avoid I could
destroy your changes with the flood when rebasing, and as a trade,
I would save a bit time, :-)

I will push the set tomorrow morning. After get an ACK on 13/13.

Regards,
Osier
On 2012年07月24日 17:18, Osier Yang wrote:
There are conflicts after splitting 2/11 and 3/11, so post the whole
set again.

v1 - v2:
   * split 2/11, and 3/11 for the patches were too big. However, the new
     3/13 is still quite big. I will send it individualy after compression.

This splits virsh.c by the command groups, except 'virsh itself' group,
each group will have a separate .c, filled with the its commands, a
few helpers, and command group definition moved from virsh.c. and virsh.c
simply include those new .c files.

It still could be optimized, but this set could set up the skelton, and
further optimization could be later patches.

Osier Yang (13):
   virsh: Move definition of cmds and cmd groups right at the top of
     main
   virsh: Split cmds for domain monitoring from virsh.c
   virsh: Split cmds of domain group from virsh.c
   virsh: Split cmds of storage volume group from virsh.c
   virsh: Split cmds of storage pool group from virsh.c
   virsh: Split cmds to manage network from virsh.c
   virsh: Split cmds to manage host interface from virsh.c
   virsh: Split cmds to manage network filter from virsh.c
   virsh: Split cmds to manage secret from virsh.c
   virsh: Split cmds to manage domain snapshot from virsh.c
   virsh: Split cmds in host group from virsh.c
   virsh: Split cmds in node device group from virsh.c
   virsh: Move command group definition into its own file

  tools/virsh-domain-monitor.c | 1701 ++++
  tools/virsh-domain.c         | 8139 +++++++++++++++++++
  tools/virsh-host.c           |  839 ++
  tools/virsh-interface.c      | 1032 +++
  tools/virsh-network.c        |  710 ++
  tools/virsh-nodedev.c        |  402 +
  tools/virsh-nwfilter.c       |  324 +
  tools/virsh-pool.c           | 1442 ++++
  tools/virsh-secret.c         |  373 +
  tools/virsh-snapshot.c       | 1628 ++++
  tools/virsh-volume.c         | 1462 ++++
  tools/virsh.c                |18474 +-----------------------------------------
  12 files changed, 18361 insertions(+), 18165 deletions(-)
  create mode 100644 tools/virsh-domain-monitor.c
  create mode 100644 tools/virsh-domain.c
  create mode 100644 tools/virsh-host.c
  create mode 100644 tools/virsh-interface.c
  create mode 100644 tools/virsh-network.c
  create mode 100644 tools/virsh-nodedev.c
  create mode 100644 tools/virsh-nwfilter.c
  create mode 100644 tools/virsh-pool.c
  create mode 100644 tools/virsh-secret.c
  create mode 100644 tools/virsh-snapshot.c
  create mode 100644 tools/virsh-volume.c

Regards,
Osier

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]