[libvirt] [PATCH 13/13] virsh: Move command group definition into its own file

[Osier Yang]

On 2012年07月26日 00:06, Martin Kletzander wrote:
> On 07/24/2012 11:18 AM, Osier Yang wrote:
>> * virsh-domain-monitor.c: Add domMonitoringCmds
>> * virsh-domain.c: Add domManagementCmds
>> * virsh-host.c: Add hostAndHypervisorCmds
>> * virsh-interface.c: Add ifaceCmds
>> * virsh-network.c: Add networkCmds
>> * virsh-nodedev.c: Add nodedevCmds
>> * virsh-nwfilter.c: Add nwfilterCmds
>> * virsh-pool.c: Add storagePoolCmds
>> * virsh-secret.c: Add secretCmds
>> * virsh-snapshot.c: Add snapshotCmds
>> * virsh-volume.c: Add storageVolCmds
>> * virsh.c: Remove all the above *Cmds.
>> ---
>>   tools/virsh-domain-monitor.c |   16 ++
>>   tools/virsh-domain.c         |   95 +++++++++++++
>>   tools/virsh-host.c           |   19 +++
>>   tools/virsh-interface.c      |   32 ++++
>>   tools/virsh-network.c        |   22 +++
>>   tools/virsh-nodedev.c        |   19 +++
>>   tools/virsh-nwfilter.c       |   14 ++
>>   tools/virsh-pool.c           |   27 ++++
>>   tools/virsh-secret.c         |   15 ++
>>   tools/virsh-snapshot.c       |   24 +++
>>   tools/virsh-volume.c         |   22 +++
>>   tools/virsh.c                |  320 +-----------------------------------------
>>   12 files changed, 307 insertions(+), 318 deletions(-)
>>
>
> This patch is ok, but for the whole series together there are few more
> things I've found out (thanks to syntax-check, mostly):
>   - 'virsh-snapshot.c' file should be listed under the same exception as
>       'virsh-domain-monitor.c' in 'cfg.mk'
>   - All new files are missing a dot after 'Inc' in the copyright
>   - All new files need to be added to 'po/POTFILES.in'
>   - All new files should be added in the exception for 'require_config_h'
>       and 'require_config_h_first'
>   - tools/virsh.c should not have 'intprops.h' included, but
>       'virsh-domain-monitor.c' should (we really need to refactor this in
>       the future =) )

Thanks. These was fixed on my local branch.

Regards,
Osier