[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 07/11] Move LXC monitor code out into separate file



On Fri, Jul 27, 2012 at 12:22:23AM +0200, Jiri Denemark wrote:
> On Tue, Jul 24, 2012 at 14:22:49 +0100, Daniel P. Berrange wrote:
> > +
> > +#define VIR_FROM_THIS VIR_FROM_LXC
> > +
> > +struct _virLXCMonitor {
> > +    int refs;
> > +
> > +    virMutex lock; /* also used to protect fd */
> 
> Which fd are you referring to?

The 'fd' which no longer exists :-) I guess we only
use this for the ref count now, since 'client' has
its own internal locking. I'll update the comment.

> 
> > +
> > +    virDomainObjPtr vm;
> > +    virLXCMonitorCallbacksPtr cb;
> > +
> > +    virNetClientPtr client;
> > +};


> >          virDomainConfVMNWFilterTeardown(vm);
> >  
> >          virSecurityManagerRestoreAllLabel(driver->securityManager,
> 
> The reference counting and locking is not ideal throughout this patch.

I'll investigate this and re-post this patch.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]