[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/5] Add callback to virNetClient to be invoked on connection close



On Thu, Jul 26, 2012 at 03:17:21PM +0200, Jiri Denemark wrote:
> On Tue, Jul 24, 2012 at 14:17:03 +0100, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > Allow detection of socket close in virNetClient via an callback
> 
> s/an/a/
> 
> > function, triggered on any condition that causes the socket to
> > be close.
> 
> s/close/closed/
> 
> > 
> > Signed-off-by: Daniel P. Berrange <berrange redhat com>
> > ---
> >  src/libvirt_private.syms |    2 +-
> >  src/rpc/virnetclient.c   |   35 +++++++++++++++++++++++++++++++----
> >  src/rpc/virnetclient.h   |    9 +++++++++
> >  3 files changed, 41 insertions(+), 5 deletions(-)
> > 
> > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> > index 734c881..83ca99f 100644
> > --- a/src/libvirt_private.syms
> > +++ b/src/libvirt_private.syms
> > @@ -1319,7 +1319,7 @@ virNetClientSendNoReply;
> >  virNetClientSendNonBlock;
> >  virNetClientSendWithReply;
> >  virNetClientSendWithReplyStream;
> > -virNetClientSetEOFNotify;
> > +virNetClientSetCloseCallback;
> >  virNetClientSetSASLSession;
> >  virNetClientSetTLSSession;
> 
> Oops, how did virNetClientSetEOFNotify sneak in?

A patch approving a global cleanup of the virNetClient syms was approved
and I cherry-picked it, not realizing it contained this symbol from a
patch not yet approved


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]