[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] maint: avoid regression on copyright listings



On 07/27/2012 03:21 AM, Osier Yang wrote:
> On 2012年07月27日 07:14, Eric Blake wrote:
>> Commit f9ce7dad6 tried to kill uses of a raw street address, but
>> missed a few instances.  Automate things so we don't introduce
>> new problems in the future.
>>

>>   # You should have received a copy of the GNU Lesser General Public
>> -# License along with this library; if not, write to the Free Software
>> -# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
>> 02111-1307  USA
>> -
>> +# License along with this library; if not,
>> see<http://www.gnu.org/licenses/>.
> 
> To be consistent. It should be:
> 
>  # License along with this library;  If not, see
>  # <http://www.gnu.org/licenses/>.
> 
> ACK with that change.

Actually, I prefer the two-line version - we already had it in-tree in
files such as tests/start.  But three-line dominates the code base, and
switching between two and three lines is cosmetic; I did it via:

$ sed -i -e 's/^\([^a-zA-Z]*\)\(.*\)see <http/\1\2see\n\1<http/' $(git
grep -l 'see <http')

and pushed the results.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]