[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] s/Un/De in virConnectUnregisterCloseCallback



On 07/30/2012 10:30 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> Previous APIs have used the word 'Deregister' rather than
> 'Unregister', so rename the recently added API to match.
> ---
>  include/libvirt/libvirt.h.in |    2 +-
>  src/libvirt.c                |    8 ++++----
>  src/libvirt_public.syms      |    2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)

ACK.  Now's the time to do it, before we lock in the API.

> +++ b/src/libvirt_public.syms
> @@ -548,7 +548,7 @@ LIBVIRT_0.9.14 {
>      global:
>          virDomainGetHostname;
>          virConnectRegisterCloseCallback;
> -        virConnectUnregisterCloseCallback;
> +        virConnectDeregisterCloseCallback;

Of course, this name change alters sorting...

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]