[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-glib 2/2] RFC: Make use of GUINT_TO_POINTER/GPOINTER_TO_UINT



On Mon, Jul 30, 2012 at 6:30 PM, Zeeshan Ali (Khattak)
<zeeshanak gnome org> wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak gnome org>
>
> We create struct and a free function each time we need to pass a simple
> unsigned integer to an async function. Code can be simplified if we
> don't do that but rather use glib's API to convert to/from uint to
> pointer.
>
> This patch only changes this for one of these functions. I'll change
> other functions when/if there is a consensus on this..

Personally, I prefer consistency with the rest of the async functions,
and I often found myself replacing GUINT_TO_POINTER "trick" with a
real pointer to a structure that can be extended.


-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]