[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: don't export avahi syms when unused



On Mon, Jul 30, 2012 at 17:31:20 -0600, Eric Blake wrote:
> Detected when building --without-avahi.
> 
> * src/libvirt_private.syms (virnetservermdns.h): Move...
> * src/libvirt_avahi.syms: ...to new file.
> * src/Makefile.am (USED_SYM_FILES, EXTRA_DIST): Use it.
> ---

ACK

> I'm debating whether to push this under the build-breaker rule.
> Unfortunately, while this solved my build on an Ubuntu machine,
> I have other machines which are failing for other symbols (some
> SASL related, and one for xenLinuxDomainBlockStats), so it's
> probably better to fix everything instead of just half the problem.

I agree it would be nice to fix all issues but we can fix them with several
patches, esp. since each of the issue may need to be solved in different way.

My build also fails for xenLinuxDomainBlockStats, which should be easy to fix.
The symbol is defined and used within Xen driver and nowhere else, thus the
following patch should solve it:

    diff --git a/src/libvirt_linux.syms b/src/libvirt_linux.syms
    index 2258739..67c1d7f 100644
    --- a/src/libvirt_linux.syms
    +++ b/src/libvirt_linux.syms
    @@ -5,7 +5,6 @@
     
     # stats_linux.h
     linuxDomainInterfaceStats;
    -xenLinuxDomainBlockStats;
     
     # nodeinfo.h
     linuxNodeInfoCPUPopulate;

However, my build also fails for 5 network symbols. I wonder if it's the same
case as with xenLinuxDomainBlockStats. It's probably worth mentioning that I
build with --without-driver-modules.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]