[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: don't export avahi syms when unused



On Tue, Jul 31, 2012 at 10:22:38 +0100, Daniel P. Berrange wrote:
> On Tue, Jul 31, 2012 at 10:54:52AM +0200, Jiri Denemark wrote:
> >     diff --git a/src/libvirt_linux.syms b/src/libvirt_linux.syms
> >     index 2258739..67c1d7f 100644
> >     --- a/src/libvirt_linux.syms
> >     +++ b/src/libvirt_linux.syms
> >     @@ -5,7 +5,6 @@
> >      
> >      # stats_linux.h
> >      linuxDomainInterfaceStats;
> >     -xenLinuxDomainBlockStats;
> >      
> >      # nodeinfo.h
> >      linuxNodeInfoCPUPopulate;
> 
> ACK to that - I see no reason for it to be exported.

Thanks, I pushed this.

> > However, my build also fails for 5 network symbols. I wonder if it's the same
> > case as with xenLinuxDomainBlockStats. It's probably worth mentioning that I
> > build with --without-driver-modules.
> 
> Can you show me what the actual symbols you see are

All symbols from libvirt_network.syms:

Expected symbol networkAllocateActualDevice is not in ELF library
Expected symbol networkBuildDhcpDaemonCommandLine is not in ELF library
Expected symbol networkGetNetworkAddress is not in ELF library
Expected symbol networkNotifyActualDevice is not in ELF library
Expected symbol networkReleaseActualDevice is not in ELF library

According to nm, they are all in libvirt_driver_network.a:

0000000000005760 T networkAllocateActualDevice
00000000000036a0 T networkBuildDhcpDaemonCommandLine
00000000000065c0 T networkGetNetworkAddress
0000000000005f50 T networkNotifyActualDevice
00000000000062c0 T networkReleaseActualDevice

but none of them makes it into the final libvirt library.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]