[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 3/3] Only perform symbol check against libvirt.so



From: "Daniel P. Berrange" <berrange redhat com>

The 'check-symfile' test case was checking the contents of
libvirt.syms against libvirt.so + all of libvirt_driver_XXX.so
This was in fact bogus - libvirt.syms should only refer to
stuff in libvirt.so, but it had some symbols from the various
driver modules in it too. Now that libvirt.syms has been
fixed, the check-symfile test can be simplified to only
consider libvirt.so
---
 src/Makefile.am |   41 ++---------------------------------------
 1 file changed, 2 insertions(+), 39 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 44350c8..3f6c7f5 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -306,45 +306,8 @@ PDWTAGS = \
 	  echo 'WARNING: install the dwarves package to get pdwtags' >&2; \
 	fi
 
-ALL_ELF_LIBS = $(builddir)/.libs/libvirt.so
-if WITH_DRIVER_MODULES
-if WITH_QEMU
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_qemu.so
-endif
-if WITH_LXC
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_lxc.so
-endif
-if WITH_UML
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_uml.so
-endif
-if WITH_XEN
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_xen.so
-endif
-if WITH_LIBXL
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_libxl.so
-endif
-if WITH_NETCF
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_interface.so
-endif
-if WITH_NETWORK
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_network.so
-endif
-if WITH_NODE_DEVICES
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_nodedev.so
-endif
-if WITH_NWFILTER
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_nwfilter.so
-endif
-if WITH_SECRETS
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_secret.so
-endif
-if WITH_STORAGE
-ALL_ELF_LIBS += $(builddir)/.libs/libvirt_driver_storage.so
-endif
-endif
-
-check-symfile: libvirt.syms $(ALL_ELF_LIBS:%.so=%.la)
-	$(AM_V_GEN)$(PERL) $(srcdir)/check-symfile.pl libvirt.syms $(ALL_ELF_LIBS)
+check-symfile: libvirt.syms $(builddir)/.libs/libvirt.la
+	$(AM_V_GEN)$(PERL) $(srcdir)/check-symfile.pl libvirt.syms $(builddir)/.libs/libvirt.so
 
 PROTOCOL_STRUCTS = \
 	$(srcdir)/remote_protocol-structs \
-- 
1.7.10.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]