[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 2/2] virsh: Allow users to reedit rejected XML



On 01.06.2012 18:20, Eric Blake wrote:
> On 06/01/2012 07:01 AM, Michal Privoznik wrote:
>> If users *-edit but make a mistake in XML all changes are
>> permanently lost. However, if virsh is not running within
>> a script we can ask user if he wants to re-edit the file
>> and correct the mistakes.
>> ---
>>  tools/console.c    |   40 ++++++++++++++++++++++-------------
>>  tools/console.h    |    2 +
>>  tools/virsh-edit.c |   38 ++++++++++++++++++++++++++++++----
>>  tools/virsh.c      |   57 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 117 insertions(+), 20 deletions(-)
> 
> ACK.
> 

Thank you. I've fixed those small nits you pointed out and pushed.
Lets see how users like it.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]