[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] syntax-check: Don't check virsh.c for preprocessor indentation



On 06/04/2012 03:36 AM, Michal Privoznik wrote:
> With recent re-edit commits we have #define and #include not
> indented as it ought to be from preprocessor POV. However, these
> are part of a function, therefore they are indented well.
> To solve this, skip preprocessor indentation check on virsh.c
> ---
>  cfg.mk |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/cfg.mk b/cfg.mk
> index 5d38137..0153024 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -830,3 +830,6 @@ exclude_file_name_regexp--sc_unmarked_diagnostics = \
>    ^(docs/apibuild.py|tests/virt-aa-helper-test)$$
>  
>  exclude_file_name_regexp--sc_size_of_brackets = cfg.mk
> +
> +exclude_file_name_regexp--sc_preprocessor_indentation = \
> +  ^tools/virsh.c$$

NAK - this is a big enough file that using the hammer of excluding the
file just for these few uses means we are more likely to have confusing
indentation on the other uses.  I'd rather see the # in column 1, even
if it looks a bit odd in context of function statements.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]