[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 9/9] virsh: add support for virConnectListAllDomains and clean up cmdList



On 06/05/2012 05:07 PM, Eric Blake wrote:
> On 06/05/2012 07:19 AM, Peter Krempa wrote:
>> This patch makes use of the newly added api virConnectListAllDomains()
>> to list domains in virsh.
> 
> I would rebase this patch to come right after 1/9 but before any driver
> implementation.  Why?  Because then you will have automatic testing that
> the fallback code actually works, prior to implementing the new API in
> later patches.  In fact, I'm reviewing it out of order (before 5/9) so
> that I can test the fallback mode first.

> 
> Question - should we be adding new flags to virsh.c for 'virsh list',
> and therefore new documentation to virsh.pod, to expose the new
> filtering bits?  But that would be okay as a followup patch.  I've got a
> pending patch series in my sandbox for virDomainListAllSnapshots, where
> I split things into adding new filter arguments in virsh prior to adding
> the new list API (hmm, I'd better dust that work off and get it posted
> now, but it is based on top of this as-yet-unreviewed series, if you
> want to trade reviews :)

Here's a link to that thread, so we can take the best ideas from each
other in our next round of posting.

https://www.redhat.com/archives/libvir-list/2012-June/msg00284.html

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]