[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] snapshot: implement new APIs for qemu, esx, and vbox

On 06/11/2012 01:14 AM, Osier Yang wrote:
> On 2012年05月25日 11:33, Eric Blake wrote:
>> The two APIs are rather trivial; based on bits and pieces of other
>> existing APIs.  Rather than blindly return 0 or 1 for HasMetadata,
>> I chose to first validate that the snapshot in question in fact
>> exists.

> Looks like it doesn't have metadata anyway for esx and vbox driver,
> is it useful then?

Right now, we have:

qemu: always uses metadata [*]
esx, vbox: never uses metadata (instead, the driver queries the
hypervisor every time)

[*] but this may change - I can see adding a flag to let the qemu driver
report snapshots without metadata, corresponding to qcow2 internal images

Furthermore, the existence of metadata is useful to know; with qemu, a
snapshot prevents deletion of a persistent domain, with esx and vbox,
all domains are persistent but the existence of a snapshot has no effect
on the ability to delete the domain.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]