[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] rpc: Fix memleak in virNetMessageEncodeHeader



On 11.06.2012 15:20, Eric Blake wrote:
> On 06/11/2012 06:28 AM, Michal Privoznik wrote:
>> My latest patch for RPC rework (a2c304f6872) introduced a memory leak.
>> virNetMessageEncodeHeader() is calling VIR_ALLOC_N(msg->buffer, ...)
>> despite fact, that msg->buffer isn't VIR_FREE()'d on all paths calling
>> the function. Therefore, rather than injecting free statement switch to
>> VIR_REALLOC_N().
>> ---
>>  src/rpc/virnetmessage.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> ACK.
> 

Thanks, pushed.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]