[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/6] snapshot: virsh indentation cleanup



On 06/11/2012 07:52 AM, Peter Krempa wrote:
> On 06/09/12 06:34, Eric Blake wrote:
>> No semantic change; this will make it easier to refactor code.
>>
>> * tools/virsh.c (cmdSnapshotList): Drop level of indentation, and
>> rename a variable.
>> ---
> 
> git show -b is the magic formula to help with indentation patch review :)
> 
> ACK

Thanks; pushed.

When reviewing 5/6 myself before posting, I found it easiest to compare
the new code in one window side-by-side with the existing
cmdSnapshotList code in another window.  Now that the indentation and
naming is similar, the differences boil down to a different
representation (single struct instead of parallel arrays) and deleting
entries from that array.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]