[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] qemuProcessStop: Switch to flags



On 06/11/2012 08:29 AM, Michal Privoznik wrote:
> Currently, we are passing only one boolean (migrated) so there is
> no real profit in this. But it creates starting position for
> next patch.
> ---
>  src/qemu/qemu_driver.c    |   16 ++++++++--------
>  src/qemu/qemu_migration.c |   20 +++++++++++++-------
>  src/qemu/qemu_process.c   |   22 ++++++++++++----------
>  src/qemu/qemu_process.h   |    8 ++++++--
>  4 files changed, 39 insertions(+), 27 deletions(-)

ACK - fairly mechanical and straightforward.

> @@ -3985,7 +3985,8 @@ void qemuProcessStop(struct qemud_driver *driver,
>  
>      /* Reset Security Labels */
>      virSecurityManagerRestoreAllLabel(driver->securityManager,
> -                                      vm->def, migrated);
> +                                      vm->def,
> +                                      flags & VIR_QEMU_PROCESS_STOP_MIGRATED);

It's a bit odd that virSecurityManagerRestoreAllLabel uses an int
instead of a bool, but that's independent of your patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]