[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv3 01/12] lib: Add public api to enable atomic listing of guest

On 06/11/2012 04:33 AM, Peter Krempa wrote:
> This patch adds a new public api that lists domains. The new approach is
> different from those used before. There are key points to this:
> 1) The list is acquired atomically and contains both active and inactive
> domains (guests). This eliminates the need to call two different list
> APIs, where the state might change in between the calls.
> 2) The returned list consists of virDomainPtrs instead of names or ID's
> that have to be converted to virDomainPtrs anyways using separate calls
> for each one of them. This is more convenient and saves hypervisor calls.
> 3) The returned list is auto-allocated. This saves a lot of hassle for
> the users.
> 4) Built in support for filtering. The API call supports various
> filtering flags that modify the output list according to user needs.

> ---
> Diff to v2:
> - doc tweaks and spelling corrections
> - return NULL in the return array on error

Looks good.  ACK to this patch (although you'll have to rebase it now
for a minor conflict resolution), to commit to the interface, while we
hash out any details in the remainder of the series.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]