[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] snapshot: implement new APIs for qemu, esx, and vbox



On 06/11/2012 08:31 AM, Osier Yang wrote:
> On 2012年06月11日 20:41, Eric Blake wrote:
>> On 06/11/2012 01:14 AM, Osier Yang wrote:
>>> On 2012年05月25日 11:33, Eric Blake wrote:
>>>> The two APIs are rather trivial; based on bits and pieces of other
>>>> existing APIs.  Rather than blindly return 0 or 1 for HasMetadata,
>>>> I chose to first validate that the snapshot in question in fact
>>>> exists.
>>>>

>>
>> Furthermore, the existence of metadata is useful to know; with qemu, a
>> snapshot prevents deletion of a persistent domain, with esx and vbox,
>> all domains are persistent but the existence of a snapshot has no effect
>> on the ability to delete the domain.
>>
> 
> It's fine for qemu driver, as there will be changes in
> future.

I've gone ahead and pushed the qemu changes.  I'll post two alternatives
for a v2 for the esx and vbox patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]